Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (entity selector) render drawer within the Grapher frame #3500

Merged
merged 1 commit into from
May 3, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Apr 16, 2024

Summary

  • The drawer shouldn't be rendered outside of Grapher (like the current Settings drawer is); instead, the drawer should be an overlay within the Grapher frame that slides in from the right (I misunderstood the designs 🤦🏻‍♀️)
Screenshot 2024-04-17 at 11 35 03

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sophiamersmann sophiamersmann force-pushed the refactor-entity-selector branch from 5694f41 to f6b54b6 Compare April 26, 2024 12:23
@sophiamersmann sophiamersmann force-pushed the entity-selector-drawer branch from a3b2213 to 16ebb02 Compare April 26, 2024 12:23
@sophiamersmann sophiamersmann force-pushed the refactor-entity-selector branch from f6b54b6 to 89c7dc6 Compare April 26, 2024 17:03
@sophiamersmann sophiamersmann force-pushed the entity-selector-drawer branch from 16ebb02 to f4672f3 Compare April 26, 2024 17:04
@sophiamersmann sophiamersmann force-pushed the refactor-entity-selector branch from 89c7dc6 to 7cd848d Compare May 1, 2024 13:07
@sophiamersmann sophiamersmann force-pushed the entity-selector-drawer branch from f4672f3 to b02c8f4 Compare May 1, 2024 13:07
@owidbot
Copy link
Contributor

owidbot commented May 1, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-entity-selector-drawer

SVG tester: Number of differences (default views): 1237

Number of differences (all views): 389

Edited: 2024-05-01 15:51:57 UTC
Execution time: 1.19 seconds

@sophiamersmann sophiamersmann force-pushed the refactor-entity-selector branch from 7cd848d to 674214b Compare May 2, 2024 14:03
@sophiamersmann sophiamersmann force-pushed the entity-selector-drawer branch from b02c8f4 to bef0398 Compare May 2, 2024 14:03
Copy link
Member Author

sophiamersmann commented May 3, 2024

Merge activity

@sophiamersmann sophiamersmann force-pushed the refactor-entity-selector branch from 674214b to f54fd14 Compare May 3, 2024 08:23
Base automatically changed from refactor-entity-selector to master May 3, 2024 08:24
@sophiamersmann sophiamersmann force-pushed the entity-selector-drawer branch from bef0398 to 2dda98c Compare May 3, 2024 08:25
@sophiamersmann sophiamersmann merged commit a204d03 into master May 3, 2024
11 of 17 checks passed
@sophiamersmann sophiamersmann deleted the entity-selector-drawer branch May 3, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants